Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve testing with Preact & React 18, etc #48

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

brodybits
Copy link
Collaborator

related issues:

TODO:

  • squash commits
  • fix & cleanup commit message

- wrap some updates in act() wrapper from react-dom/test-utils
  (or preact/test-utils for Preact), using simple actWith()
  test utility function in many cases, to get
  some tests working with Preact & React 18
- update CI workflow labels
- show console warnings for tests that still need to be skipped
- other minor updates

related issues:

- #40
- #41
@brodybits brodybits marked this pull request as ready for review January 31, 2023 14:07
@brodybits brodybits merged commit 6afc637 into main Jan 31, 2023
@brodybits brodybits deleted the improve-testing-on-preact-etc branch January 31, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant