Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove title={} from resource #114

Closed
1 task done
jovana opened this issue Nov 9, 2023 · 4 comments · Fixed by #117
Closed
1 task done

remove title={} from resource #114

jovana opened this issue Nov 9, 2023 · 4 comments · Fixed by #117
Labels
bug Something isn't working

Comments

@jovana
Copy link

jovana commented Nov 9, 2023

Checklist

  • I've verified that I'm running react-big-schedule version 4.2.0 or higher

Describe the bug

Using JSX on the resource setter:

{
                        id: element.product_id,
                        parentId: 0,
                        title: element.product_name,
                        name: <Flex justify="space-between" gap={5}>
                                <div className="product-label">{element.product_name}</div>
                            </Flex>,
                    }

The title on the resource buttons gives: [object Object]. Not sure why this title's has been set. You can find it here:

<div style={{ width }} title={resourceEvents.slotName} className="overflow-text header2-text">

and here:

<div title={item.slotName} className="overflow-text header2-text" style={{ textAlign: 'left' }}>

Possible to rename to title={resourceEvents.slotTitle} instead of using title={resourceEvents.slotName}.

Also, make more send to have this aligned using the title from the resource setter instead of the name.

Reproduction Link/Code

Scherm­afbeelding 2023-11-09 om 09 52 03 Scherm­afbeelding 2023-11-09 om 09 52 07

Steps to reproduce

Using "react-big-schedule": "^4.3.2",

Operating System

MacOSX

Browser

Chromium

React version

18.2

react-big-schedule version

"react-big-schedule": "^4.3.2",

Additional Information

No response

@jovana jovana added the bug Something isn't working label Nov 9, 2023
@ansulagrawal
Copy link
Member

@jovana thank you for pointing out the issue I will do it in next week as I am busy now. If you can do it, it will be very wonderful.

@ansulagrawal ansulagrawal linked a pull request Nov 22, 2023 that will close this issue
ansulagrawal added a commit that referenced this issue Nov 22, 2023
@ansulagrawal
Copy link
Member

ansulagrawal commented Nov 22, 2023

@jovana please use 4.3.3-beta.1 version and check.

you need to pass title in resources

{ id: 'r0', name: 'Resource0', title: 'Resource 0', groupOnly: true },

@ansulagrawal ansulagrawal reopened this Nov 23, 2023
@jovana
Copy link
Author

jovana commented Jan 22, 2024

I have installed the latest version now. The reported issue has been resolved! Many thanks!!
I will close this bug report now.

@jovana jovana closed this as completed Jan 22, 2024
@ansulagrawal
Copy link
Member

ansulagrawal commented Jan 23, 2024

Thank you @jovana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants