Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint Configration #93

Merged
merged 19 commits into from
Aug 14, 2023
Merged

ESLint Configration #93

merged 19 commits into from
Aug 14, 2023

Conversation

ansulagrawal
Copy link
Member

No description provided.

@ansulagrawal ansulagrawal linked an issue Aug 3, 2023 that may be closed by this pull request
Fix ESLint Errors in Several Files #92
Closed
@ansulagrawal
Copy link
Member Author

Still Chages Required in below files:

  1. react-big-schedule/src/components/SchedulerData.js
  2. react-big-schedule/src/components/DnDSource.js
  3. react-big-schedule/src/components/DnDContext.js

@ansulagrawal
Changes:
c08897e 
1. Disable `react/forbid-prop-types` in eslint
2.  Fix Eslint error in `Add More.jsx`, `AddMorePopover.jsx`.
3. Formated and fix eslint error in `HeaderView.jsx`.
4. Fix File: `SchedulerHeader.jsx`.
5. Converted arrow base to functional base `WrapperFun.jsx`
@ansulagrawal
Fix Formating
8c5b292
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 6, 2023
View reviewed changes
scripts/build.js Dismissed Show dismissed Hide dismissed
codeclimate[bot]
codeclimate bot reviewed Aug 7, 2023
View reviewed changes
src/components/DnDContext.js
let { slotId, slotName } = resourceEvents;
let action = 'New';
const isEvent = type === DnDTypes.EVENT;
if (isEvent) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical blocks of code found in 2 locations. Consider refactoring.

codeclimate[bot]
codeclimate bot reviewed Aug 14, 2023
View reviewed changes
src/components/DnDSource.js
newEnd = localeDayjs(newStart)
.add(localeDayjs(event.end).diff(localeDayjs(event.start)), 'ms')
const isEvent = type === DnDTypes.EVENT;
if (isEvent) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Identical blocks of code found in 2 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Aug 14, 2023

Code Climate has analyzed commit e90a956 and detected 27 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 26
Bug Risk 1

View more on Code Climate.

@ansulagrawal ansulagrawal merged commit 564ff61 into master Aug 14, 2023
4 of 5 checks passed
@ansulagrawal ansulagrawal deleted the config/eslint branch August 14, 2023 19:15
@DamyanBG
Copy link
Contributor

Hey, how is going?

@ansulagrawal
Copy link
Member Author

Configuration is done need to fix eslint errors

@ansulagrawal
Copy link
Member Author

I am busy now so may take more time, if you have time please continue

@DamyanBG
Copy link
Contributor

Unfortunately these days I am really busy, but I will try to find some time.

@ansulagrawal
Copy link
Member Author

ansulagrawal commented Aug 18, 2023 •
edited

No problem, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeclimate codeclimate[bot] codeclimate left review comments

@DamyanBG DamyanBG DamyanBG approved these changes

Assignees
No one assigned
Labels
Code Refactoring eslint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ESLint Errors in Several Files
3 participants
@ansulagrawal @DamyanBG @code-factor