Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Create React App's eslint setup #19

Closed
cr101 opened this issue Oct 10, 2017 · 5 comments
Closed

Implement Create React App's eslint setup #19

cr101 opened this issue Oct 10, 2017 · 5 comments
Labels
enhancement 🦄 Changing current behaviour, enhancing what's already there

Comments

@cr101
Copy link

cr101 commented Oct 10, 2017

Please consider implementing Eslint which does a much better job of explaining JS errors than browsers do which is helpful for everyone but especially beginners.

@tannerlinsley tannerlinsley added the enhancement 🦄 Changing current behaviour, enhancing what's already there label Oct 11, 2017
@tannerlinsley
Copy link
Contributor

Have you tried the built-in eslint configuration?

@cr101
Copy link
Author

cr101 commented Oct 12, 2017

@tannerlinsley I have not yet but I've used CRA's eslint and it's incredibly useful. I'm considering porting an app built with CRA over and I'm not sure what the implications would be.

@tannerlinsley
Copy link
Contributor

React-Static doesn't prescribe a linter during the build stages, but does ship with an .eslintrc configuration that works with Prettier and eslint. Closing this for now :)

@axhamre
Copy link

axhamre commented Mar 26, 2018

I've been missing this a lot as well.

Edit
It was actually very easy to install eslint-config-react-app as devDependency, so my comment was unnecessary.

@JustFly1984
Copy link

JustFly1984 commented Mar 26, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🦄 Changing current behaviour, enhancing what's already there
Projects
None yet
Development

No branches or pull requests

4 participants