-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Create React App's eslint setup #19
Comments
Have you tried the built-in eslint configuration? |
@tannerlinsley I have not yet but I've used CRA's eslint and it's incredibly useful. I'm considering porting an app built with CRA over and I'm not sure what the implications would be. |
React-Static doesn't prescribe a linter during the build stages, but does ship with an .eslintrc configuration that works with Prettier and eslint. Closing this for now :) |
I've been missing this a lot as well. Edit |
Please don't embed eslint-config-react-app.
@hundsim You can install in as devDependency and globaly, extend from it in
.eslintrc Right now I can say that this config is not required for
development at all, since we have fresh react-tools config.
2018-03-27 4:56 GMT+08:00 hundsim <notifications@github.com>:
… I've been missing this a lot as well. Found the package that includes the
shareable ESLint configuration used by Create React App:
eslint-config-react-app
<https://www.npmjs.com/package/eslint-config-react-app>, and it should be
possible to integrate:
"If you want to use this ESLint configuration in a project not built with
Create React App, you can install it with following steps..."
Unfortunately though, despite the easy 2-step path to implement those
configs, I couldn't get it to work :/
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACJsee19_Go8MU7UQbgJ5n9WdEqPMZnHks5tiVXrgaJpZM4Pzrhh>
.
|
Please consider implementing Eslint which does a much better job of explaining JS errors than browsers do which is helpful for everyone but especially beginners.
The text was updated successfully, but these errors were encountered: