Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add option to only build static files and disable JS #618

Closed
dillonbheadley opened this issue May 21, 2018 · 13 comments
Closed

Feature: Add option to only build static files and disable JS #618

dillonbheadley opened this issue May 21, 2018 · 13 comments
Labels
enhancement 🦄 Changing current behaviour, enhancing what's already there

Comments

@dillonbheadley
Copy link

It would be great to have the option to not include the SPA on the client. This would give us some more options for the end user. While the client side routing is fast, it can sometimes use more bandwidth than necessary for the end user and possibly more memory which could be a problem for some devices.

Disabling the SPA could result in a better result for the end user in some cases.

@tannerlinsley
Copy link
Contributor

We could also support some logic that would conditionally mount the SPA in specific circumstances. This way you could detect if the device is worthy of the SPA or not and act accordingly. Thoughts?

@tannerlinsley tannerlinsley added enhancement 🦄 Changing current behaviour, enhancing what's already there RFP labels May 23, 2018
@dan-dr
Copy link

dan-dr commented Jun 19, 2018

Couldn't this be easily done by simply not mounting the App component and just exporting it from src/index.js ? If so, it's just a matter of documentation

@stale
Copy link

stale bot commented Jul 19, 2018

This issue has been automatically marked as stale because it has not had recent activity in 7 days. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 19, 2018
@tannerlinsley
Copy link
Contributor

tannerlinsley commented Jul 19, 2018 via email

@stale stale bot removed the stale label Jul 19, 2018
@stale
Copy link

stale bot commented Aug 18, 2018

This issue has been automatically marked as stale because it has not had recent activity in 7 days. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 18, 2018
@tannerlinsley
Copy link
Contributor

tannerlinsley commented Aug 20, 2018 via email

@stale stale bot removed the stale label Aug 20, 2018
@tannerlinsley tannerlinsley changed the title Add option to only build static files and not hydrate with SPA on client Feature: Add option to only build static files and disable JS Sep 7, 2018
@stale
Copy link

stale bot commented Oct 7, 2018

This issue has been automatically marked as stale because it has not had recent activity in 30 days. It will be closed in another 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 7, 2018
@Pixelatex
Copy link
Collaborator

Not stale

@stale stale bot removed the stale label Oct 7, 2018
@stale
Copy link

stale bot commented Nov 6, 2018

This issue has been automatically marked as stale because it has not had recent activity in 30 days. It will be closed in another 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 6, 2018
@Dragomir-Ivanov
Copy link

Not stale

@stale stale bot removed the stale label Nov 7, 2018
@stale
Copy link

stale bot commented Dec 7, 2018

This issue has been automatically marked as stale because it has not had recent activity in 30 days. It will be closed in another 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 7, 2018
@Dragomir-Ivanov
Copy link

Not stale

@stale stale bot removed the stale label Dec 7, 2018
@tannerlinsley
Copy link
Contributor

After some deep thinking on this subject, I don't think it's going to be possible to do this any time soon. Going to move this issue into the vault for now. We may revisit this in future breaking versions of React Static

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🦄 Changing current behaviour, enhancing what's already there
Projects
None yet
Development

No branches or pull requests

5 participants