Allow plugins to modify routeInfo #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,39 +1,6 @@ | |||
| import { getHooks, reduceHooks } from '../utils' | |||
|
|
|||
| const supportedHooks = [ | |||
There was a problem hiding this comment.
What's the reason these ae removed? Even though they don't have a default implementation, are you certain they're not actually supported anymore?
There was a problem hiding this comment.
All the entries in the array are also keys in the exported object. So I just removed the duplication. validatePlugin now takes the valid hook names from the exported object.
There was a problem hiding this comment.
GitHub was collapsing those lines, so I didn't realise. This is good. Thanks :)
# Conflicts: # CHANGELOG.md
SleeplessByte
approved these changes
Feb 20, 2021
|
(It's still a draft, but overall this is looking good to me) |
|
Thanks @SleeplessByte |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow plugins to modify routeInfo to for example add or modify the data that is used on a page.
Changes/Tasks
Motivation and Context
#1566
Types of changes
Checklist: