Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent endless suspense loop #1573

Merged
merged 2 commits into from Feb 19, 2021
Merged

Prevent endless suspense loop #1573

merged 2 commits into from Feb 19, 2021

Conversation

andreme
Copy link
Contributor

@andreme andreme commented Feb 19, 2021 •
edited

Changes/Tasks

Store original React.Suspense in the Suspense component instead of using the default, which will be itself.

Motivation and Context

closes #1564

Types of changes

  • Refactoring/add tests (refactoring or adding test which isn't a fix or add a feature)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have updated the documentation accordingly
  • I have updated the CHANGELOG with a summary of my changes
  • My changes have tests around them

SleeplessByte
SleeplessByte approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this looks good haha

@SleeplessByte SleeplessByte merged commit f8dc77c into react-static:master Feb 19, 2021
@andreme andreme deleted the fix/suspense_endless_loop branch February 19, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SleeplessByte SleeplessByte SleeplessByte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Out of Memory with basic template
2 participants
@andreme @SleeplessByte