Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: JS error when use lineNumberStyle() for inline line numbers #296

Merged

Conversation

ktmud
Copy link
Contributor

@ktmud ktmud commented Aug 12, 2020

Fix a JS error when using lineNumberStyle as a function for inline line numbers.

When running the tests locally, there were also two failing tests which I was not sure know how to fix.

 FAIL  __tests__/light-async.js
  ● SyntaxHighlighter renders fortran highlighted text

    expect(received).toMatchSnapshot()

    Snapshot name: `SyntaxHighlighter renders fortran highlighted text 1`

    - Snapshot  - 658
    + Received  +  25

 FAIL  __tests__/prism-async-light.js
  ● When the code split is loaded - SyntaxHighlighter renders python highlighted text after async loading python

    expect(received).toMatchSnapshot()

    Snapshot name: `When the code split is loaded - SyntaxHighlighter renders python highlighted text after async loading python 1`

    - Snapshot  - 1162
    + Received  +   25

@simmerer
Copy link
Collaborator

Thanks for this PR, @ktmud! Looks good to me. Tested locally, and I don't see the test failures that you experienced in those two async tests. We sorta-recently resolved some issues there.

@simmerer simmerer merged commit 7cc2983 into react-syntax-highlighter:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants