Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chip's avatar inside card displayed as block #1195

Closed
wiikka opened this issue Jan 31, 2017 · 1 comment
Closed

Chip's avatar inside card displayed as block #1195

wiikka opened this issue Jan 31, 2017 · 1 comment

Comments

@wiikka
Copy link

wiikka commented Jan 31, 2017 •
edited

Used themr, but I assume problem is in react-toolbox. Inside card avatars have style display: block, but if I want to use chip with avatar inside card it should inline-block. Seems like a bug or is there restriction in Google Material that chip shouldn't be used inside card? Beta 6.
@javivelasco
Copy link
Member

That rule was assuming Avatar is known inside Card so it was wrong, thanks! :)

ankitladhania pushed a commit to ankitladhania/react-toolbox that referenced this issue Feb 9, 2017
Merge branch 'dev' of github.com:react-toolbox/react-toolbox into dev
bb052c8 
* 'dev' of github.com:react-toolbox/react-toolbox: (119 commits)
  Fix react-toolbox#1219
  Allow numbers for Input value prop. Fixes react-toolbox#1180
  Move eslint-plugin-babel to devDependencies (react-toolbox#1222)
  Move gulp-rimraf to devDependencies (react-toolbox#1214)
  Eslint plugin compat
  Remove tests from build and remove sinon
  Use Jest 🃏 and upgrade Webpack and other dependencies
  Fixes react-toolbox#1086 (react-toolbox#1212)
  Import Ramda values function directly (react-toolbox#1209)
  Fixes react-toolbox#1195
  How to hide AppBar icon based on permanentAt value (react-toolbox#1194)
  Bugfix: Propert selector for disabled value in Dropdown
  Move `react-style-proptype` to non-dev deps (react-toolbox#1190)
  handle defaultValue to <Input /> (react-toolbox#1178)
  Add $input-icon-right-space var to add the correct spacing to the input based on Material Spec. (react-toolbox#1188)
  fixed broken link (react-toolbox#1181)
  Update Changelog
  Release 2.0.0-beta.6
  Update dependencies
  Fix tests
  ...
ankitladhania pushed a commit to ankitladhania/react-toolbox that referenced this issue May 29, 2017
Merge branch 'dev'
9327715 
* dev: (121 commits)
  Adding event to radio group
  Revert "Merge branch 'dev' of github.com:react-toolbox/react-toolbox into dev"
  Fix react-toolbox#1219
  Allow numbers for Input value prop. Fixes react-toolbox#1180
  Move eslint-plugin-babel to devDependencies (react-toolbox#1222)
  Move gulp-rimraf to devDependencies (react-toolbox#1214)
  Eslint plugin compat
  Remove tests from build and remove sinon
  Use Jest 🃏 and upgrade Webpack and other dependencies
  Fixes react-toolbox#1086 (react-toolbox#1212)
  Import Ramda values function directly (react-toolbox#1209)
  Fixes react-toolbox#1195
  How to hide AppBar icon based on permanentAt value (react-toolbox#1194)
  Bugfix: Propert selector for disabled value in Dropdown
  Move `react-style-proptype` to non-dev deps (react-toolbox#1190)
  handle defaultValue to <Input /> (react-toolbox#1178)
  Add $input-icon-right-space var to add the correct spacing to the input based on Material Spec. (react-toolbox#1188)
  fixed broken link (react-toolbox#1181)
  Update Changelog
  Release 2.0.0-beta.6
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@javivelasco @wiikka