Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List ListItem Ripple effect Issue #1205

Closed
devarsh opened this issue Feb 1, 2017 · 3 comments
Closed

List ListItem Ripple effect Issue #1205

devarsh opened this issue Feb 1, 2017 · 3 comments

Comments

@devarsh
Copy link

devarsh commented Feb 1, 2017

The ripple effect moves outside the bounds of the element, I've copied the example straight from docs, this occurs only with List.

Library Version
react 15.4.2
react-toolbox ^2.0.0-beta.6

Image

@leonardobaggio
Copy link

Same issue here, 2.0.0-beta.6.

@devarsh
Copy link
Author

devarsh commented Feb 2, 2017

There is a typo error, which accidently passes ripple boolean to theme, which causes the classname to be set undefined.

I don't have the setup else i would post a PR is a very simple change.

https://github.com/react-toolbox/react-toolbox/blob/dev/components/list/ListItem.js#L75

@gustavohenke
Copy link
Contributor

#1215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants