Widen typing for Layout children to 'any' #1572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I'm getting agnostic-typescript branch as a mirror of dev plus some experiences that should be eventually merged so I'd rather make the PR to dev if possible :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for #1542 . See microsoft/TypeScript#13618 for additional details as well, TS doesn't appear to have a good solve for this issue at this time. For now, this change widens the requirement for
Layoutchildren to be anany.It's not ideal, but does allow react-toolbox to be used with TS 2.3 and 2.4, where this did not work previously.
EDIT: Targeting
agnostic-typescript, as this appears to be the current branch npm releases are coming from, but I could be mistaken. Let me know and I can re-target.