Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sub-generator setup-env #278 #308

Merged
merged 1 commit into from Nov 22, 2016
Merged

Added sub-generator setup-env #278 #308

merged 1 commit into from Nov 22, 2016

Conversation

sthzg
Copy link
Member

@sthzg sthzg commented Nov 22, 2016

This subgen creates a new Webpack config environment by

  • creating conf/webpack/.js
  • creating src/config/<env_name>.js
  • requiring and exporting the new env in conf/webpack/index.js

The commit introduces a basic config template that is supposed to be populated by the generator's users. Various more fine grained subgen options can be added at a later time (e.g. prompting the user if new run scripts should be added to package.json).

The subgen's basic functionality is backed up by unit tests that check

  • if files are created
  • if conf/webpack/index.js contains correct import/export

This subgen creates a new Webpack config environment by

- creating conf/webpack/<EnvName>.js
- creating src/config/<env_name>.js
- requiring and exporting the new env in conf/webpack/index.js

The commit introduces a basic config template that is supposed to be populated by the generator's users. Various more fine grained subgen options can be added at a later time (e.g. prompting the user if new run scripts should be added to package.json).

The subgen's basic functionality is backed up by unit tests that check

- if files are created
- if conf/webpack/index.js contains correct import/export
@sthzg sthzg merged commit 01855bd into master Nov 22, 2016
@sthzg sthzg deleted the feature/gh_issue_278 branch November 22, 2016 18:38
@coveralls
Copy link

coveralls commented Nov 22, 2016

Coverage Status

Coverage decreased (-0.2%) to 96.016% when pulling 7a74813 on feature/gh_issue_278 into a2bd75a on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants