Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #20

Merged
merged 17 commits into from
Apr 30, 2024
Merged

Refactor #20

merged 17 commits into from
Apr 30, 2024

Conversation

mayank1513
Copy link
Member

@mayank1513 mayank1513 commented Apr 30, 2024

Completed Tasks

  1. Removed serverValue as it is irrelevant in this context.
  2. Refactored code for better minification.
  3. Added options to (and renamed) the persist plugin (or middleware).
  4. Updated documentation.
  5. Updated license to MPL-2.0.
  6. Addressed potential user concerns:
    • What if a user wants to use useRGSWithPlugin in multiple components? - Utilize doNotInit, the fourth argument of the hook.
    • What if a user wants to provide an initial value from within the component but define the hook using the create function? - Employ withPlugins higher-order function.

To-do [help needed]

  • fix doc comments for withPlugins

@mayank1513 mayank1513 self-assigned this Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (ecc8aa6) to head (7b71f71).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         5    +1     
  Lines          227       286   +59     
  Branches        30        51   +21     
=========================================
+ Hits           227       286   +59     
Flag Coverage Δ
r18gs 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

deepsource-io bot commented Apr 30, 2024

Here's the code health analysis summary for commits e95286d..7b71f71. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

lib/r18gs/src/utils.ts Dismissed Show dismissed Hide dismissed
@mayank1513
Copy link
Member Author

Update README

@mayank1513 mayank1513 marked this pull request as draft April 30, 2024 10:36
@mayank1513 mayank1513 marked this pull request as ready for review April 30, 2024 14:35
@mayank1513 mayank1513 merged commit 7219caf into main Apr 30, 2024
8 checks passed
@mayank1513 mayank1513 deleted the refactor branch April 30, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant