fix(select): pass event as first argument in onchange handlers

react95-io · Apr 11, 2020 · c862996 · c862996
1 parent d372912
commit c862996
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/src/components/Slider/Slider.js b/src/components/Slider/Slider.js
@@ -349,10 +349,10 @@ const Slider = React.forwardRef(function Slider(props, ref) {
     setFocusVisible(true);
 
     if (onChange) {
-      onChange(newValue);
+      onChange(event, newValue);
     }
     if (onChangeCommitted) {
-      onChangeCommitted(newValue);
+      onChangeCommitted(event, newValue);
     }
   });
 
@@ -396,7 +396,7 @@ const Slider = React.forwardRef(function Slider(props, ref) {
     setFocusVisible(true);
 
     if (onChange) {
-      onChange(newValue);
+      onChange(event, newValue);
     }
   });
   const handleTouchEnd = useEventCallback(event => {
@@ -409,7 +409,7 @@ const Slider = React.forwardRef(function Slider(props, ref) {
     const newValue = getNewValue(finger);
 
     if (onChangeCommitted) {
-      onChangeCommitted(newValue);
+      onChangeCommitted(event, newValue);
     }
 
     touchId.current = undefined;
@@ -434,7 +434,7 @@ const Slider = React.forwardRef(function Slider(props, ref) {
     setFocusVisible(true);
 
     if (onChange) {
-      onChange(newValue);
+      onChange(event, newValue);
     }
     const doc = ownerDocument(sliderRef.current);
     doc.addEventListener('mousemove', handleTouchMove);
@@ -456,7 +456,7 @@ const Slider = React.forwardRef(function Slider(props, ref) {
     setFocusVisible(true);
 
     if (onChange) {
-      onChange(newValue);
+      onChange(event, newValue);
     }
 
     const doc = ownerDocument(sliderRef.current);

diff --git a/src/components/Slider/Slider.spec.js b/src/components/Slider/Slider.spec.js
@@ -332,8 +332,8 @@ describe('<Slider />', () => {
       );
 
       expect(handleChange).toHaveBeenCalledTimes(2);
-      expect(handleChange.mock.calls[0][0]).toBe(80);
-      expect(handleChange.mock.calls[1][0]).toBe(78);
+      expect(handleChange.mock.calls[0][1]).toBe(80);
+      expect(handleChange.mock.calls[1][1]).toBe(78);
     });
   });