chore: make shadow props (insetShadow) opt-in #277
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c4c2825:
|
WesSouza
force-pushed
the
shadow-false-default
branch
from
2d929ec
to
c4c2825
Compare
luizbaldi
reviewed
Jul 18, 2022
There was a problem hiding this comment.
LGTM! But we'd have to release a new patch version so we don't affect our existing users.
Thoughts here @arturbien?
|
Changed approach to #283. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a while to realize the inner shadow added to all controls were not a Safari artifact, but a default option from the library.
This PR inverts that logic, bringing the UI closer to what Windows 95 actually displayed, and allowing users to enable the inner shadow only if they want to.