-
-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scrolling issue in storybook #408
Comments
I noticed it yesterday 😂 We had overflow previously on GlobalStyle but it wasn't the right place to add it. But removing the overflow from GlobalStyle breaks places where it is necessary, as you noticed. I think this can be fixed in some storybook configuration. Would you like to contribute? |
I'm not super familiar with Storybook config stuff and thus was hesitant to open a PR, but I'd be open to fork it and fix it. I'll put up a PR at some point in the next few days and close out this issue. Read thru the |
After thinking more about this, I think the best approach here would be to revert #376 as the GlobalStyle doesn't try to mimic a Windows95 screen. So, removing this line will fix the issue. Don't need to worry about storybook config. I'd also encourage you to play around with all the components if you don't mind. Maybe you'll find more places to contribute, who knows... 😃 |
Cleaning up some older code that uses this package and was taking a look at the storybook to find some new icons. Noticed that scrolling is disallowed, thus preventing me from scrolling through any of the icons :(
Did some digging and found importing
GlobalStyle
intoFrame.tsx
here pulls in anoverflow: hidden
style on the body of the storybook frames. Setting overflow to hidden seems to be essential within actual applications built with React95 as it prevents the desktop from being scrollable, but using this in the storybook prevents some of the stories from being fully viewable by users like me.The text was updated successfully, but these errors were encountered: