Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Hero Header Section #77

Closed
8 tasks
orama254 opened this issue Oct 13, 2022 · 2 comments · Fixed by #105
Closed
8 tasks

Implement Hero Header Section #77

orama254 opened this issue Oct 13, 2022 · 2 comments · Fixed by #105
Assignees
Labels
hacktoberfest Hactoberfest participation Tag help wanted Extra attention is needed oss-ke osske

Comments

@orama254
Copy link
Member

orama254 commented Oct 13, 2022

Depends on

What feature are you adding?

Hero Header Section

Describe your issue

Requirements

  • Create a component named HeroHeader in the components folder that implements the screenshots below.
  • It should make use of the existing Navbar component - feel free to adjust the Navbar component to match the requirements in this ticket.
  • The menu items are anchor links which should smoothly scroll to the relevant section when clicked.
  • The sections do not need to exist for this ticket, only ensure that the links are correct.
  • Reuse the Logo and Button components.
  • Obtain the hero image from the Figma design. Use THIS VIDEO as a guide
  • Include the component in index.page.tsx.
  • Create a new test file in the e2e folder named hero-header.spec.ts and add a test that verifies that clicking each of the 5 links in the component navigates to the correct URLs.

SCREENSHOT

Desktop

hero-section

Mobile
hero-section-mobile

Figma Design

Acceptance Criteria

  • When the "About Us" menu is clicked, the URL changes to /#about-us.
  • When the "Events" menu is clicked, the URL changes to /#events.
  • When the "Contact" menu is clicked, the URL changes to /#contact-us.
  • When the "Join Community" button is clicked, the page opens https://bit.ly/joinreactdevske in a new tab.
  • When the "Join ReactDevsKE" button is clicked, the page opens https://bit.ly/joinreactdevske in a new tab.
  • The implementation should match the design - text content, typography, capitalization and spacing.
  • The UI should be responsive and work well on both desktop and mobile viewports.
  • The hero-header.spec.ts test should pass on both Chrome, Firefox and Safari.
@orama254 orama254 added help wanted Extra attention is needed oss-ke osske up-for-grabs This issue is NOT assigned to anyone. Grab it hacktoberfest Hactoberfest participation Tag labels Oct 13, 2022
@orama254 orama254 added this to To do in reactdevske Website Oct 13, 2022
@devKiratu
Copy link
Contributor

Hi @orama254 , please assign me this issue

@orama254
Copy link
Member Author

Hey @devKiratu

Go ahead, remember to go through our contribution guidelines and also evaluate the acceptance criteria before submitting a pull request.

Happy hacking!!!

@orama254 orama254 removed the up-for-grabs This issue is NOT assigned to anyone. Grab it label Oct 25, 2022
@orama254 orama254 moved this from To do to In progress in reactdevske Website Oct 25, 2022
@orama254 orama254 moved this from In progress to Done in reactdevske Website Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hactoberfest participation Tag help wanted Extra attention is needed oss-ke osske
Projects
Development

Successfully merging a pull request may close this issue.

2 participants