Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Button Component #85

Closed
3 tasks
orama254 opened this issue Oct 13, 2022 · 7 comments · Fixed by #86
Closed
3 tasks

Implement the Button Component #85

orama254 opened this issue Oct 13, 2022 · 7 comments · Fixed by #86
Assignees
Labels
hacktoberfest Hactoberfest participation Tag help wanted Extra attention is needed oss-ke osske

Comments

@orama254
Copy link
Member

orama254 commented Oct 13, 2022

What feature are you adding?

Button Component

Describe your issue

Requirements

  • Button
    • Create a component named Button in the components folder that implements the screenshots below.
    • It should use the native HTML button element.
    • It should accept all HTML button props.
  • Link
    • Create a component named LinkButton in the components folder that implements the screenshots below.
    • It should use the native HTML a element.
    • It should accept all HTML a props.
  • Both buttons should handle long labels by hiding the overflow with an ellipsis.
  • Both buttons should match the design.

SCREENSHOTS

Figma Design

Acceptance Criteria

  • The implementation should match the design - typography and spacing.
  • The buttons should be responsive and work well on both desktop and mobile viewports.
  • Long labels should be handled correctly.
@orama254 orama254 added help wanted Extra attention is needed oss-ke osske up-for-grabs This issue is NOT assigned to anyone. Grab it hacktoberfest Hactoberfest participation Tag labels Oct 13, 2022
@enowdivine
Copy link
Contributor

Hi @orama254 Please assign the button component to me.

@orama254
Copy link
Member Author

Hey @enowdivine

Go ahead, remember to go through our contribution guidelines and also evaluate the acceptance criteria before submitting a pull request.

Happy hacking!!!

@orama254 orama254 removed the up-for-grabs This issue is NOT assigned to anyone. Grab it label Oct 13, 2022
@orama254
Copy link
Member Author

@enowdivine

ALSO NOTE: This issue has some other dependencies, eg #77 & #82 How soon do you think you can submit a PR?

@orama254 orama254 added this to In progress in reactdevske Website Oct 13, 2022
@enowdivine
Copy link
Contributor

@enowdivine

ALSO NOTE: This issue has some other dependencies, eg #77 & #82 How soon do you think you can submit a PR?

ok noted. I can submit a PR in a day maximum.

@enowdivine
Copy link
Contributor

Hello @orama254 the figma design link leads to no where. Please can you check that

@orama254
Copy link
Member Author

My bad @enowdivine

It should be all good now, nice catch.

Let me know if there is anything else you would want assistance with.

@enowdivine
Copy link
Contributor

Ok sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hactoberfest participation Tag help wanted Extra attention is needed oss-ke osske
Projects
Development

Successfully merging a pull request may close this issue.

2 participants