Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing the pillar component [Fixes #79] #101

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Implementing the pillar component [Fixes #79] #101

merged 2 commits into from
Oct 24, 2022

Conversation

AJ-Kulundu
Copy link
Contributor

Fixes Issue

Closes #79
Implements Pillar Component design according to the Figma design.

Changes proposed

  • Implements a component named Pillar in the components folder.
  • Implements a responsive design for both desktop and mobile, and an ellipsis to for text overflow.
  • The component has two props: counter and label, both of which are string types.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Desktop Pillar component
desktop pillar
Mobile Pillar Component
mobile-pillar

@vercel
Copy link

vercel bot commented Oct 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
reactdevske-website ✅ Ready (Inspect) Visit Preview Oct 24, 2022 at 8:29AM (UTC)

antosan
antosan requested changes Oct 22, 2022
View reviewed changes
src/components/Pillar/Pillar.tsx Outdated Show resolved Hide resolved
src/components/Pillar/Pillar.tsx Outdated Show resolved Hide resolved
antosan
antosan approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@antosan antosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@antosan antosan added the hacktoberfest-accepted Hacktoberfest acceptance tag label Oct 24, 2022
@antosan antosan merged commit 8a41fe4 into reactdeveloperske:develop Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antosan antosan antosan approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Hacktoberfest acceptance tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the Pillar Component
2 participants
@AJ-Kulundu @antosan