Fix "accept answer" double-sending in some cases #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vcarl
reviewed
Feb 3, 2022
definoob
commented
Feb 3, 2022
Comment on lines
+19
to
+32
| const checkIfBotReplied = ( | ||
| messages: Collection<string, Message<boolean>>, | ||
| ): boolean => { | ||
| let flag = 0; | ||
|
|
||
| messages.forEach((message) => { | ||
| if (message.content.includes("This question has an answer!")) { | ||
| flag++; | ||
| } | ||
| }); | ||
|
|
||
| return flag > 0; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Let me know if I can improve this function in any way.
vcarl
reviewed
Feb 3, 2022
Comment on lines
+22
to
+30
| let flag = 0; | ||
|
|
||
| messages.forEach((message) => { | ||
| if (message.content.includes("This question has an answer!")) { | ||
| flag++; | ||
| } | ||
| }); | ||
|
|
||
| return flag > 0; |
There was a problem hiding this comment.
What about: (prettier might complain, my dev laptop is out of commission atm)
Suggested change
| let flag = 0; | |
| messages.forEach((message) => { | |
| if (message.content.includes("This question has an answer!")) { | |
| flag++; | |
| } | |
| }); | |
| return flag > 0; | |
| return messages.some((message) => | |
| message.content.includes("This question has an answer!") | |
| ); |
vcarl
reviewed
Feb 3, 2022
| @@ -41,3 +42,6 @@ export const fetchReactionMembers = ( | |||
| .then((users) => | |||
| Promise.all(users.map((user) => guild.members.fetch(user.id))), | |||
| ); | |||
|
|
|||
| export const fetchMessagesByUser = (thread: ThreadChannel, userID: string) => | |||
| thread.messages.cache.filter((message) => message.author.id === userID); | |||
There was a problem hiding this comment.
This relies on the messages being cached, which won't be true for threads that were created before the bot restarted. Is it feasible to make this something like, thread.messages.fetch()? (I don't have a dev computer handy or I'd check, sorry)
vcarl
reviewed
Feb 3, 2022
Comment on lines
+74
to
+79
| const threadMessages = fetchMessagesByUser( | ||
| thread as ThreadChannel, | ||
| reactibot, | ||
| ); | ||
|
|
||
| if (checkIfBotReplied(threadMessages)) { |
There was a problem hiding this comment.
A couple notes:
fetchMessagesByUseris a relatively expensive call, I think we should move it further down in the logic so it's only run when absolutely necessary -- we have less expensive calls that can bail out earlier- I'd prefer to avoid
as, as that bails out of type checking. There's athread.isThread()assertion that perserves type safety. There's an implied "return early if it's not a thread" here, maybe we could make that more explicit and move this code further down to remove the need to cast
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check who the current reaction is from and reply only when the thread author reacted. Closes #173