Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch Img to ProgressiveImage #227

Closed
aldeed opened this issue Aug 14, 2018 · 0 comments · Fixed by #362 or #483
Closed

Switch Img to ProgressiveImage #227

aldeed opened this issue Aug 14, 2018 · 0 comments · Fixed by #362 or #483
Assignees
@rosshadden
Milestone
Oxford

Comments

@aldeed
Copy link
Contributor

aldeed commented Aug 14, 2018

Work

The Img component has been replicated in the component library. Remove Img from starter kit and update all <Img /> uses to the one from the component library. For the product grid hero image, the isHero prop and its associated CSS padding has been removed, so add a wrapper div with the necessary styles to keep it looking the same.
@aldeed aldeed added this to the Kit Carson milestone Aug 14, 2018
@spencern spencern modified the milestones: Kit Carson, Little Bear Aug 21, 2018
@spencern spencern modified the milestones: Little Bear, Massive Sep 4, 2018
@spencern spencern modified the milestones: Massive, North Maroon Sep 18, 2018
@spencern spencern modified the milestones: North Maroon, Oxford Oct 2, 2018
@rosshadden rosshadden self-assigned this Oct 4, 2018
@rosshadden rosshadden mentioned this issue Oct 4, 2018
Merged
This was referenced Jan 15, 2019
Closed
Merged
@spencern spencern mentioned this issue Jan 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rosshadden rosshadden

Labels
None yet
Projects
None yet
Milestone
Oxford
3 participants
@rosshadden @spencern @aldeed