Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recheck setSearch and remove or replace it in context/RoutingContext.js #674

Closed
willopez opened this issue Jun 4, 2020 · 0 comments
Closed

Recheck setSearch and remove or replace it in context/RoutingContext.js #674

willopez opened this issue Jun 4, 2020 · 0 comments
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration help wanted For issues that have a clear solution described and are not currently prioritized core team work

Comments

@willopez
Copy link
Member

willopez commented Jun 4, 2020 •
edited
Loading

Type: Refactor

Describe the bug
Recheck setSearch and remove or replace it in context/RoutingContext.js. See for context: #667 (comment)

Expected behavior
setSearh should correctly set query string params.
@willopez willopez added chore For issues that describe a task that does not affect the release, such as tests or CI configuration help wanted For issues that have a clear solution described and are not currently prioritized core team work labels Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration help wanted For issues that have a clear solution described and are not currently prioritized core team work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@delagroove @willopez