Skip to content
This repository has been archived by the owner on Jun 2, 2021. It is now read-only.

For Prerender.IO make protocol type(https or http) to be load from env settings #46

Open
zenweasel opened this issue May 1, 2018 · 0 comments

Comments

@zenweasel
Copy link
Collaborator

@amalan-shenll commented on Mon Apr 30 2018

In RC 1.11.0, in prerender.js
prerender.set("prerenderToken", process.env.PRERENDER_TOKEN);
prerender.set("host", process.env.PRERENDER_HOST);
prerender.set("protocol", "https");
this is code for prerender.io configuration.
it allows to env variable for prerenderToken and host.

issue
prerender.io always redirecting to https where our demo site support only http

reason
prerender.set("protocol", "https");

expecting change
pls change hardcoded protocol to load from env setting like
prerender.set("protocol", process.env.PRERENDER_PROTOCOL);
https://github.com/reactioncommerce/reaction/blob/7a7612033fcb044156945f6949169f8019296186/server/startup/prerender.js#L9
which may allow developers to set protocol type in env settings

Thank You

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant