Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DDPRateLimit to all exposed client methods #1267

Closed
Capt-Slow opened this issue Aug 8, 2016 · 3 comments
Closed

Add DDPRateLimit to all exposed client methods #1267

Capt-Slow opened this issue Aug 8, 2016 · 3 comments

Comments

@Capt-Slow
Copy link
Contributor

Capt-Slow commented Aug 8, 2016

This ticket is in reference to #344.

For DoS protection we should wrap all client facing methods with DDPRateLimit.

(More detailed actions items to come) Might/will need to break this ticket down even further.

@zenweasel
Copy link
Collaborator

First task would be to delineate the methods (pretty much anything public client facing) and determine where the upper limit of what a reasonable use case would be.

@zenweasel zenweasel removed their assignment Aug 11, 2016
@jshimko
Copy link
Contributor

jshimko commented Aug 12, 2016

FYI, I added some initial rate limiting for accounts and email notification methods in #1282.

https://github.com/reactioncommerce/reaction/blob/8e822d134918688b3c81f4467d97020a99f64280/server/security/rate-limits.js

@aaronjudd aaronjudd added this to Ideas in Core May 2, 2017
@aaronjudd aaronjudd removed this from Ideas in Core May 2, 2017
@aaronjudd aaronjudd removed the backlog label May 2, 2017
@aaronjudd
Copy link
Contributor

Closing - insufficient details. Will be handled as part of next architecture as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants