Payment provider name inconsistently translated

[zenweasel]

Expected behavior

All payment provider names should either be translated or not translated (probably not translated?)

Actual Behavior

Some are and some are not.

Steps to Reproduce the Behavior

1. Log in as an admin
2. Go to Payment in the dashboard
3. Set language to be something besides English
4. Observe that some payment providers are translated, some are not.

[aaronjudd]

PayPal etc probably are brands.. not translatable word? not sure though..

[zenweasel]

Right, but Stripe should probably not be translated, as well as Braintree.

[zenweasel]

"Example Payment Method" could be translated, since it's not brand

[aaronjudd]

True. Is there a translation in i18n?

[zenweasel]

[{
  "language": "Arabic",
  "i18n": "ar",
  "ns": "reaction-stripe",
  "translation": {
    "reaction-payments": {
      "admin": {
        "shortcut": {
          "stripeLabel": "شريط"
        },
        "dashboard": {
          "stripeLabel": "شريط",
          "stripeDescription": "المدفوعات شريط"
        },
        "paymentSettings": {
          "stripeLabel": "شريط",
          "stripeSettingsLabel": "شريط",
          "stripeSettingsDescription": "لم يكن لديك معرف العميل الشريط API؟",
          "stripeSettingsGetItHere": "أحضره هنا"
        }
      }
    }
  }
}]

[zenweasel]

Trying to change these in LingoHub (I had already modified a bunch of these in code but some I can't really fix). But when I go into LingoHub the word shows as "locked" with the status "ordered". Have a support request in with LIngoHub

[aaronjudd]

I actually think you need to leave a message for their support, I think that we paid for some translations that were never fulfilled...

[zenweasel]

I have been working in Lingo hub to set up "Terms" which you can specify global translations but I keep getting distracted or need to ask their support a question so I get delayed a day to wait for their response. So progress is happening, just super slowly.

[zenweasel]

I didn't finish this in time for the 1.1.1 release so moving to 1.2

[aaronjudd]

@spencern this is the issue where the payment providers were being corrected (discussed re: #2167)

@zenweasel issue with LingoHub is now resolved, and these translations can also be fixed there.

[zenweasel]

So I added terms for items below and marked them "untranslatable". That seems to work well. I just don't know how to trigger a PR from that change. I have a question in with support. But that seems like it will take care of it.

Let me know if you think of more:

Authorize.net
Braintree
PayPal/PayPal Express/ Paypal Pro
Shippo
Stripe
Avalara
TaxCloud

[zenweasel]

Closed via #2218