Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Shipped" button on orders panel returns blank panel #2136

Closed
joykare opened this issue Apr 18, 2017 · 5 comments
Closed

"Shipped" button on orders panel returns blank panel #2136

joykare opened this issue Apr 18, 2017 · 5 comments
Labels
bug For issues that describe a defect or regression in the released software
Projects

Comments

@joykare
Copy link
Contributor

joykare commented Apr 18, 2017

When I click on "Shipped" I get an empty panel.

Actual Behavior

bad_shipping

@joykare joykare added the orders label Apr 18, 2017
@zenweasel zenweasel added the bug For issues that describe a defect or regression in the released software label Apr 18, 2017
@aaronjudd aaronjudd added this to the Marketplace Orders milestone Apr 26, 2017
@aaronjudd aaronjudd removed the orders label May 1, 2017
@aaronjudd
Copy link
Contributor

This is duplicated (with some error reporting) in #2142. Closing that issue.

@aaronjudd
Copy link
Contributor

From @spencern

Steps to reproduce

  1. Clone release-1.1.1
  2. reaction reset
  3. meteor npm install
  4. reaction run
  5. setup stripe & enable all three default Flat Rate shipping options
  6. Place Order from incognito window
  7. Click into order from notifications panel
  8. Attempt to fulfill order

No console errors were shown when attempting to fulfill order, but dashboard action panel appears empty and when clicking the <- back arrow throws the following error.

main.js:354 Uncaught TypeError: Cannot read property 'pop' of undefined
    at Object.popActionView (http://localhost:3000/app/app.js?hash=cefcfaa4796cc18f5ea7d77d168df51176564e34:66581:20)
    at Object.handleActionViewBack [as onClick] (http://localhost:3000/app/app.js?hash=cefcfaa4796cc18f5ea7d77d168df51176564e34:30053:12)
    at Button._this.handleClick (http://localhost:3000/app/app.js?hash=cefcfaa4796cc18f5ea7d77d168df51176564e34:39219:21)
    at Object.ReactErrorUtils.js.ReactErrorUtils.invokeGuardedCallback (http://localhost:3000/packages/modules.js?hash=f8877f8ddab1183cef2c3299adca352ccd2d7707:119400:16)
    at executeDispatch (http://localhost:3000/packages/modules.js?hash=f8877f8ddab1183cef2c3299adca352ccd2d7707:119180:21)
    at Object.executeDispatchesInOrder (http://localhost:3000/packages/modules.js?hash=f8877f8ddab1183cef2c3299adca352ccd2d7707:119203:5)
    at executeDispatchesAndRelease (http://localhost:3000/packages/modules.js?hash=f8877f8ddab1183cef2c3299adca352ccd2d7707:118587:22)
    at executeDispatchesAndReleaseTopLevel (http://localhost:3000/packages/modules.js?hash=f8877f8ddab1183cef2c3299adca352ccd2d7707:118598:10)
    at Array.forEach (native)
    at forEachAccumulated (http://localhost:3000/packages/modules.js?hash=f8877f8ddab1183cef2c3299adca352ccd2d7707:119507:9)

Which is throwing an error from here:

 popActionView: function () {                                                                                         //
    var actionViewStack = Session.get("admin/actionView");                                                             //
    actionViewStack.pop();                                                                                             // 354
    Session.set("admin/actionView", actionViewStack);                                                                  //
    this.setActionViewDetail({}, {                                                                                     //
      open: false                                                                                                      // 358
    });                                                                                                                //
  },     

image

@aaronjudd
Copy link
Contributor

@kieckhafer not closed, not resolved in several weeks, open back up to the team? (unless you want to take it back on)

@kieckhafer
Copy link
Member

kieckhafer commented May 16, 2017

This issue is fixed in the changes made in #2280

shipping mov

@kieckhafer kieckhafer moved this from Bugs to Done in Components May 16, 2017
@spencern
Copy link
Contributor

@aaronjudd and @zenweasel I propose that we open #2142 back up if it's still not fixed so there is a more specific issue to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
No open projects
Development

No branches or pull requests

6 participants