Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert settings panels to React #2198

Closed
brent-hoover opened this issue May 2, 2017 · 7 comments
Closed

Convert settings panels to React #2198

brent-hoover opened this issue May 2, 2017 · 7 comments
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration
Projects

Comments

@brent-hoover
Copy link
Collaborator

The Example Payment is already React so just convert Paypal, Braintree, Authorize, and Stripe. Add validation to Example Payment. Use @mikemurray's Reaction-Autoform

@brent-hoover brent-hoover self-assigned this May 2, 2017
@aaronjudd aaronjudd added this to the React UI Components milestone May 3, 2017
@kieckhafer kieckhafer added this to Ready in Components May 15, 2017
@brent-hoover brent-hoover removed their assignment Aug 7, 2017
@brent-hoover brent-hoover added the chore For issues that describe a task that does not affect the release, such as tests or CI configuration label Oct 4, 2017
@brent-hoover
Copy link
Collaborator Author

This should be done by using the <Form> component rather than the way it was done in Example Payment (and example payment should be rewritten to do this as well).

This should work so that in most cases unless you have advanced needs that you only need to define your schema and your settings panel should be generated automatically. So this may require extending the <Form> component some.

If this gets too big because some settings panels are more complicated (e.g. Avalara) then we can create additional tickets.

@brent-hoover brent-hoover changed the title Convert payment settings panels to React Convert settings panels to React Oct 4, 2017
@foladipo
Copy link
Contributor

foladipo commented Oct 10, 2017

Here's a complete list of the parts of the Dashboard panels that are yet to be converted:

  • Actions
    • Analytics
  • Settings
    • Account settings
      • Facebook Sign in
      • Google Sign in
      • Instagram Sign in
      • Twitter Sign in
    • Connectors
      • Shopify Connect Settings
    • Shop
      • General
      • Address
      • Options
      • Marketplace
    • Localization and i18n
      • Shop Localization
      • Languages
      • Currencies
    • Payment
      • Default Provider
      • Codes
      • Authorize.net
      • Braintree
      • Example Provider
      • PayPal Express
      • PayPal PayFlow
    • Catalog
      • Product Revisions (the panel heading itself. The section below it that shows "Revision controls is enabled" is a React component.)
    • Tax
      • Custom Rates
      • Avalara
      • TaxCloud
    • Analytics
      • Segment
    • Search
      • Product Search Settings
    • Shipping
      • Flat rate (except for the carriers table and the button for creating a new rate).
      • Shippo (except for the carriers table).

@brent-hoover
Copy link
Collaborator Author

Can drill down one level further? The sections under Payment, Shipping, Tax and others would all be separate panels.

@foladipo
Copy link
Contributor

@zenweasel I've added more detail to the list.

@foladipo
Copy link
Contributor

Update: I have started work on converting the "Analytics" panel to React.

@brent-hoover
Copy link
Collaborator Author

Just to document this here:

Let start with Taxcloud, Search and SMS. These are all simple panels just a couple of text fields and/or booleans. If those go smoothly then let's move on from there.

@aldeed
Copy link
Contributor

aldeed commented Nov 27, 2019

This is currently reflected in newer and more specific issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration
Projects
No open projects
Development

No branches or pull requests

6 participants