Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove theme editor and dependencies. #2468

Closed
aaronjudd opened this issue Jun 20, 2017 · 5 comments · Fixed by #3645
Closed

Remove theme editor and dependencies. #2468

aaronjudd opened this issue Jun 20, 2017 · 5 comments · Fixed by #3645
Assignees
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration
Projects

Comments

@aaronjudd
Copy link
Contributor

We should remove/ move postcss and other remnants of the theme editor into a stand alone package, with it's own dependencies. We're importing postcss and referencing it in the client, but I'm not sure we're actually using this anymore... (@mikemurray?)

@kieckhafer kieckhafer added this to Backlog in Components Jun 20, 2017
@zenweasel zenweasel added the chore For issues that describe a task that does not affect the release, such as tests or CI configuration label Oct 20, 2017
@aldeed
Copy link
Contributor

aldeed commented Jan 17, 2018

@aaronjudd @zenweasel @spencern @mikemurray

I would like to do this ticket as well as creating a new component/style guide repo based on React Storybook as part of performance epic. I know there are still many decisions to be made about UI and style guide, but I think agreeing on managing the component library in a separate project and creating that project is the first step. This will then give us a place to quickly iterate on new components for any that we identify as slow at runtime, or slow to develop with.

Any thoughts? Are there existing issues for separating the component library and standardizing components more, other than this one?

@zenweasel
Copy link
Collaborator

@aldeed My team has a project to create this new component library. We've been using Styleguidist but no real work on components have been done yet. https://github.com/reactioncommerce/reaction-component-library

@zenweasel
Copy link
Collaborator

Here is the other main ticket re: styleguide. I think we will probably be moving all issues over to this new repo: #2267

@aldeed
Copy link
Contributor

aldeed commented Jan 23, 2018

I think can also remove juliancwirko:postcss as part of this

@aaronjudd
Copy link
Contributor Author

@nnnnat @mikemurray wrote this originally, and would be good to connect with first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore For issues that describe a task that does not affect the release, such as tests or CI configuration
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants