Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order dashboard search by orderId, customer info, order product info #2717

Merged
merged 92 commits into from Sep 15, 2017

Conversation

impactmass
Copy link
Contributor

@impactmass impactmass commented Aug 22, 2017

Resolves #2353, #2354 and #2355

How To Test

  • Create a few orders

  • Search the orders using the Search Bar at the top with:
    ** OrderId
    ** Customer info (name, email, phone, card - last 4 digits)
    ** Product title, Variant title, Variant option title

  • Confirm that all these search and any active filter takes effect on the results being displayed by the table.

  • Confirm that clearing all filters and using search alone also works.

.
The only part of this pending is opening up the order summary action view if exactly one match/result is present in the table. Currently working on making Sortable not prevent the opening, but, I think reviews can start on this. I'll get the opening in before review completion.

Update:
There is a blocker to sliding out the table when there's only one matching item because the data fetching & rendering is happening within the table itself. Since we'll be moving the fetching #2768, that seem a better time to achieve this.

@zenweasel
Copy link
Collaborator

Testing this now and search doesn't work at all. As I type results are not being updated.

  1. DId reaction reset && reaction
  2. Put in a couple of orders
  3. Type in a search term I know doesn't exist
  4. Still shows all results even though none match

order_search

@aaronjudd
Copy link
Contributor

I can confirm the same results as @zenweasel. Search does not work.
reaction

@aaronjudd aaronjudd dismissed kieha’s stale review September 13, 2017 22:01

Unable to test search.

@kieha
Copy link
Contributor

kieha commented Sep 13, 2017

Had tested this before the marketplace merges and it worked. I can, however, also confirm that search doesn't work now.

screen shot 2017-09-14 at 1 42 36 am

@joykare
Copy link
Contributor

joykare commented Sep 14, 2017

Fixed @zenweasel @kieha @aaronjudd

@zenweasel
Copy link
Collaborator

Search by phone number is not working at all

basic_reaction_product

@zenweasel
Copy link
Collaborator

Same with address
basic_reaction_product

@joykare
Copy link
Contributor

joykare commented Sep 14, 2017

@zenweasel is searching by address a new spec for the order search? It wasn't a functionality of the search before.

@zenweasel
Copy link
Collaborator

@joykare good point. Disregard that comment. I had assumed customer info included address.

@joykare
Copy link
Contributor

joykare commented Sep 14, 2017

@zenweasel phone search works now
The only caveat is if you added a + on your query your order isn't found (even if the number did have a +). Tried a couple of fixes haven't come up with one that works yet. But I think it works right now and it shouldn't be a blocker for this PR merge.

Copy link
Collaborator

@zenweasel zenweasel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be working properly now.

@aaronjudd
Copy link
Contributor

cart_checkout Seeing the navigation header during checkout, haven't seen that elsewhere, haven't noticed it before. I suspect it's not related, but @zenweasel can you confirm?

@aaronjudd
Copy link
Contributor

aaronjudd commented Sep 15, 2017

I was unable search for testing+ emails, such as aaron+1@, no results return after + , but the other search filtering seems to be working nicely.
reaction_and_order_dashboard_search_by_orderid__customer_info__order_product_info_by_impactmass_ pull_request__2717 _reactioncommerce_reaction
reaction_and_order_dashboard_search_by_orderid__customer_info__order_product_info_by_impactmass_ pull_request__2717 _reactioncommerce_reaction

@zenweasel
Copy link
Collaborator

@aaronjudd I see the same header during checkout on an unrelated up-to-date marketplace branch. Is that what you mean?

cart_checkout

@aaronjudd
Copy link
Contributor

@zenweasel yes, do we have an issue documenting that?

@aaronjudd
Copy link
Contributor

aaronjudd commented Sep 15, 2017

@zenweasel I take that back ... is that expected when logged in as admin? If so, then I'm good to go.

@zenweasel
Copy link
Collaborator

Created this issue for emails and phone numbers with + signs. #2867

Otherwise ready to go.

@zenweasel zenweasel merged commit f3a7fc2 into marketplace Sep 15, 2017
@zenweasel zenweasel deleted the seun-orders-search-2353 branch September 15, 2017 02:24
@spencern spencern mentioned this pull request Oct 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants