New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order dashboard search by orderId, customer info, order product info #2717
Conversation
…e opened in the action view panel
I can confirm the same results as @zenweasel. Search does not work. |
Fixed @zenweasel @kieha @aaronjudd |
@zenweasel is searching by address a new spec for the order search? It wasn't a functionality of the search before. |
@joykare good point. Disregard that comment. I had assumed customer info included address. |
@zenweasel phone search works now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be working properly now.
Seeing the navigation header during checkout, haven't seen that elsewhere, haven't noticed it before. I suspect it's not related, but @zenweasel can you confirm? |
@aaronjudd I see the same header during checkout on an unrelated up-to-date marketplace branch. Is that what you mean? |
@zenweasel yes, do we have an issue documenting that? |
@zenweasel I take that back ... is that expected when logged in as admin? If so, then I'm good to go. |
Created this issue for emails and phone numbers with Otherwise ready to go. |
Resolves #2353, #2354 and #2355
How To Test
Create a few orders
Search the orders using the Search Bar at the top with:
** OrderId
** Customer info (name, email, phone, card - last 4 digits)
** Product title, Variant title, Variant option title
Confirm that all these search and any active filter takes effect on the results being displayed by the table.
Confirm that clearing all filters and using search alone also works.
.
The only part of this pending is opening up the order summary action view if exactly one match/result is present in the table. Currently working on making Sortable not prevent the opening, but, I think reviews can start on this. I'll get the opening in before review completion.
Update:
There is a blocker to sliding out the table when there's only one matching item because the data fetching & rendering is happening within the table itself. Since we'll be moving the fetching #2768, that seem a better time to achieve this.