Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReactionError move to npm package #4493

Closed
3 tasks done
nnnnat opened this issue Jul 27, 2018 · 1 comment
Closed
3 tasks done

ReactionError move to npm package #4493

nnnnat opened this issue Jul 27, 2018 · 1 comment
Labels
enhancement For issues that describe a feature that needs to be added, changed, or removed, but is not a bug

Comments

@nnnnat
Copy link
Contributor

nnnnat commented Jul 27, 2018

Prerequisites

  • Are you running the latest version?
  • Are you able to consistently reproduce the issue?
  • Did you search the issue queue for existing issue? Search issues

Issue Description

We're replacing all Meteor.Error calls with the ReactionError, currently the ReactionError class is deeply nested inside /imports/plugins/core/graphql/server/no-meteor/ directories. Should the ReactionError class be ported into it's own npm package?

Possible Solution

Move ReactionError class into an npm package
import ReactionError from "@reactioncommerce/reactionerror"

Versions

1.14
@nnnnat nnnnat added question enhancement For issues that describe a feature that needs to be added, changed, or removed, but is not a bug labels Jul 27, 2018
@aldeed aldeed mentioned this issue Sep 10, 2019
Closed
45 tasks
@aldeed aldeed closed this as completed Oct 28, 2019
@aldeed
Copy link
Contributor

aldeed commented Oct 28, 2019

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement For issues that describe a feature that needs to be added, changed, or removed, but is not a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nnnnat @aldeed