Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed Shops migration for Products template #4608

Closed
aldeed opened this issue Sep 7, 2018 · 0 comments · Fixed by #4599
Closed

Missed Shops migration for Products template #4608

aldeed opened this issue Sep 7, 2018 · 0 comments · Fixed by #4599
Assignees
Labels
bug For issues that describe a defect or regression in the released software
Milestone

Comments

@aldeed
Copy link
Contributor

aldeed commented Sep 7, 2018

Issue

Migration 33 was added in v1.15.0 to change the "products" template name to "Products". It neglected to do this in the Shops collection, which also has layouts stored there. Depending on whether you are upgrading, whether your Packages collection is regenerated on startup, and what version your database is already on, this sometimes leads to the app starting as just a white screen with no errors in the console.

This is actually pretty likely to happen in an upgrade situation.

Solution

Add another migration to convert the Shops collection.

@aldeed aldeed self-assigned this Sep 7, 2018
@aldeed aldeed added the bug For issues that describe a defect or regression in the released software label Sep 7, 2018
@aldeed aldeed added this to the Massive milestone Sep 7, 2018
@aldeed aldeed changed the title Missed migration for Products template Missed Shops migration for Products template Sep 7, 2018
@aldeed aldeed closed this as completed Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant