Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to Node 18 #6396

Open
zenweasel opened this issue Dec 17, 2021 · 7 comments · Fixed by #6740
Open

Move to Node 18 #6396

zenweasel opened this issue Dec 17, 2021 · 7 comments · Fixed by #6740
Assignees
@sujithvn
Labels
core work For issues that track feature development work being done by core Reaction developers
Projects
Current Work

Comments

@zenweasel
Copy link
Collaborator

zenweasel commented Dec 17, 2021 •
edited

Node 18 is LTS. Let's try to get on top of this. Hopefully not many breaking changes if any.
@zenweasel zenweasel added the core work For issues that track feature development work being done by core Reaction developers label Dec 17, 2021
@zenweasel zenweasel added this to Plan in Current Work via automation Dec 17, 2021
@zenweasel zenweasel moved this from Plan to Icebox in Current Work Feb 4, 2022
@zenweasel zenweasel moved this from Icebox to Specify in Current Work Feb 11, 2022
@zenweasel
Copy link
Collaborator Author

zenweasel commented Mar 2, 2022 •
edited

So because of this change with the way JSON files are imported in Node 16, every package plus Reaction itself is going to need to be updated in a way that is backwards compatible. Not a lot of programming work, but a fair amount of busy work.

That is not necessarily the only change that needs to be made, but the first one I have identified

@setaman
Copy link

setaman commented Mar 7, 2022

@zenweasel

So because of this change with the way JSON files ...

This currently prevents me to use @reactioncommerce/api-core with Node 16 in a fresh project. I still need to fallback to Node 14. I would really like to have this issue resolved and could offer my support, if required.

@zenweasel zenweasel moved this from Specify to Plan in Current Work Mar 26, 2022
@zenweasel
Copy link
Collaborator Author

We may want to look at just jumping to Node 18 since that just became LTS

@alexmukho
Copy link

That would be great. Since nothing works on Macbooks with M1.

@zenweasel zenweasel changed the title Move to Node 16 Move to Node 18 Dec 2, 2022
@zenweasel
Copy link
Collaborator Author

Changing this to Node 18, since going to 16 only buys us 5 more months

@sujithvn sujithvn mentioned this issue Jan 4, 2023
Merged
@eshwaruppala
Copy link

any update on this?

@zenweasel
Copy link
Collaborator Author

There's a pr on all of the repos that's just waiting for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sujithvn sujithvn

Labels
core work For issues that track feature development work being done by core Reaction developers
Projects
Current Work
  
Plan
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade Node to 18 reactioncommerce/reaction
5 participants
@zenweasel @alexmukho @setaman @sujithvn @eshwaruppala