Move filters for the products query into a separate input type #6498
Labels
bug
For issues that describe a defect or regression in the released software
needs triage
For issues that are awaiting triage by the core development team
Projects
Issue Description
The
products
query currently defines all possible filters toplevel, making it impossible to extend:https://github.com/reactioncommerce/api-plugin-products/blob/0be4a8e31dab70475431f892b66e8ce8c3f4f6e1/src/schemas/product.graphql#L615
In comparison, this is what it looks like for the
orders
query:https://github.com/reactioncommerce/api-plugin-orders/blob/419872d845d8ed24b424510fcc7e645db85cef11/src/schemas/schema.graphql#L17
OrderFilterInput
can be extended easily, custom plugin logic would only need to extend the schema.In general I believe there still is some way to go to unify these schemas and find a more generic interface for CRUD operations.
Steps to Reproduce
products
query.Possible Solution
Move all filters into an
ProductFilterInput
type.Versions
trunk
The text was updated successfully, but these errors were encountered: