Filter for Promotions #6738
Merged
Filter for Promotions #6738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sujith <mail.sujithvn@gmail.com>
🦋 Changeset detectedLatest commit: e4dfe64 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Signed-off-by: Sujith <mail.sujithvn@gmail.com>
sujithvn
requested review from
vanpho93 and
zenweasel
and removed request for
vanpho93
Signed-off-by: Sujith <mail.sujithvn@gmail.com>
zenweasel
approved these changes
Jan 3, 2023
| @@ -315,4 +339,34 @@ extend type Query { | |||
|
|
|||
| sortOrder: String | |||
| ): PromotionConnection! | |||
|
|
|||
| "Query to get a filtered list of Accounts" | |||
vanpho93
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sujith mail.sujithvn@gmail.com
Resolves #6689
Impact: minor
Type: feature
Issue
Add filtering for Promotions collection like was done for Customer/Orders (Ticket #6689)
Solution
Added new query endpoint
filterPromotionswhich will provide the requested feature.To get a list of available fields and their type, the UI could use the new query end-point
introspectSchema(currently in PR status).Breaking changes
None.
But for passing the validate permissions, we need an entry ["reaction:legacy:promotions", "read"] which is handled in the PR #6732
Testing
Unit test for the common query function is already included in the Filter PR (6684). This PR is only adding the new end-point in the same format