Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout not responding in Storefront when Promotions are in place #6803

Open
sujithvn opened this issue Feb 16, 2023 · 0 comments
Open

Checkout not responding in Storefront when Promotions are in place #6803

sujithvn opened this issue Feb 16, 2023 · 0 comments
Labels
bug For issues that describe a defect or regression in the released software Promotions Issues related to the Promotions project

Comments

@sujithvn
Copy link
Contributor

Issue Description

During the UAT testing of Promotions, it was noticed that in a very specific scenario, the Checkout button in Storefront is not responding (no response/error). Detailed steps to reproduce the issue provided below.

Note:

  1. When you are at this error stage, if you hit F5 and refresh the screen, then this issue no longer exists and we are able to proceed with the "checkout" button taking us to login screen.

  2. The issue is reproducible for the exact same products mentioned. In case of some other product combinations, we were able to proceed without any error.

  3. The below steps were tested with trunk of reaction and there were no issues. Branch feat/promotions gave the issue in the below specific case only.

Steps to Reproduce

  1. Delete the existing reaction database
  2. Ensure you have plugins.json updated to include sample-data plugin and also update .env file to include LOAD_SAMPLE_DATA=true
  3. Start the API with pnpm --filter=reaction run start:dev
  4. Open the browser and navigate to http://localhost:4080 for Admin UI. Login with admin credentials
  5. Navigate to the Products and click on the product - "Men's Waterproof Outdoor Rain Jacket”. Set the vendor to "The North Face" and Save and Publish that product.
  6. Navigate to the Products and click on the product - "Women's Outwear Sportswear Hoodie”. Set the vendor to "Nike" and Save and Publish that product.
  7. Start Kinetic with pnpm run dev and open the browser and navigate to http://localhost:3000 for Kinetic UI. Login with admin credentials
  8. Click on Promotions from sidebar
  9. In the View All tab, select all the existing promotions (usually 3 of them) and from the Action dropdown select "Disable". Make sure all the existing promotions are "Disabled" before proceeding.
  10. From the “Actions” dropdown select “Create New”
  11. Provide a promotion name
  12. Select “Order Discount” as the promotion type
  13. Click on “Add Action”, select percentage and set percentage value as 10
  14. Open the “Excluding Products” box, select “Vendor” from property, select “Is Any Of” for condition and enter “Nike” (press enter) and “The North Face” (press enter)
  15. Select “Add Trigger”
  16. Select “Cart Value is greater than” and set the value at $1
  17. Select “Available From” and select yesterday and the “Available To” as a week from today
  18. Add the checkout label
  19. Save the promotion
  20. From the actions dropdown select “Enable”
  21. Go to the list view and select “View All” and verify the promotion is Enabled
  22. It will take a 5 minutes or slightly more for the promotion to become active. Proceed to the next step only once the promotion is marked “active”.
  23. Start Storefront with yarn run start:dev and open the browser and navigate to the http://localhost:4000/ for storefront
  24. Add the “Men’s Casual Rugged Jacket” to the cart.
  25. If you go to the Cart page, you can observe the the total of “$44.99” reflects the %10 discount on the $49.99 price
  26. Go back to Homepage and verify that the vendor for “Men’s Waterproof Outdoor Rain Jacket” is set to “The North Face”. Add this item to the cart.
  27. If you go to the Cart page, you can observe the the total of “$94.98”. Note that this second item that we added was not discounted and the total only reflects the %10 discount on the first item.
  28. At this stage, the API console does NOT show any errors and only has the informational logs.
  29. There are NO errors in the browser console also (apart from the ones for missing images).
  30. If you click the "Checkout" button, there is no response/output/errors in both the browser console and API console

Versions

Reaction - on branch feat/promotions
commit 15c2bfc (origin/feat/promotions)
Merge: d71b8ac 1bbb011

Kinetic - on branch fix/condition-fields
commit 6b0906660a9e65c16e63541f5539f84f33759a4b

@sujithvn sujithvn added bug For issues that describe a defect or regression in the released software needs triage For issues that are awaiting triage by the core development team labels Feb 16, 2023
@zenweasel zenweasel changed the title Checkout not responding in Storefront for a specific situation Checkout not responding in Storefront when Promotions are in place Feb 16, 2023
@zenweasel zenweasel added Promotions Issues related to the Promotions project and removed needs triage For issues that are awaiting triage by the core development team labels Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software Promotions Issues related to the Promotions project
Projects
None yet
Development

No branches or pull requests

2 participants