major refactoring #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kof
force-pushed
the
master
branch
3 times, most recently
from
d7cdf1d
to
a05954e
Compare
|
Any thoughts? @PixelsCommander |
|
Lets start a discussion, what do you dislike? |
|
ping |
|
Will be back from holidays on weekend. Sorry for delay |
- use browserify for modules - don’t merge components instance with custom element, as ES6 class methods are not enumerable - pass `children` and `container` to the component. Now component is responsible for exposing public methods on container or using dom events. - move utils into separate module
- use browserify for modules - don’t merge components instance with custom element, as ES6 class methods are not enumerable - pass `children` and `container` to the component. Now component is responsible for exposing public methods on container or using dom events. - move utils into separate module
|
ok, conflicts resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
methods are not enumerable
childrenandcontainerto the component. Now component isresponsible for exposing public methods on container or using dom
events.