warn if key is param of component render function #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that is, if `key` is a kwarg of the function, it will be given as None when no key was specified, and the given value otherwise.
previously key was a required parameter if it was given. initially we thought that just making it optional would be fine. however, after some thought, this could lead to unexpected behavior when users don't want 'key' to indicate identity - if it were optional the user would not get any warning when this confusion occured. As a result we will warn the user about this until, in a future release we raise an exception.
rmorshea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previously key was a required parameter if it was given when constructing the component. initially we thought that just making it optional would be fine. however, after some thought, this could lead to unexpected behavior when users don't want 'key' to indicate identity - if it were optional the user would not get any warning when this confusion occurred. As a result we will warn the user about this until, in a future release we raise an exception.