Track contexts in hooks as state #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmorshea
force-pushed
the
fix-use-context-issue
branch
from
a4d810f
to
d4c3dbc
Compare
components which are newly added to the layout after the initial render do not have access to contexts. we solve this by tracking life cycle hooks in stack and copying the context providers from parent to child hooks. we also change how contexts are implemented - instead of needing a create_context function which returns a new Context class, we just return a Context object that constructs a ContextProvider component. the earlier implementation was too clever and did not add anything for it.
rmorshea
force-pushed
the
fix-use-context-issue
branch
from
d4c3dbc
to
b0a9b06
Compare
rmorshea
force-pushed
the
fix-use-context-issue
branch
from
75130e8
to
f6b326e
Compare
|
@Archmonger, thoughts on removing |
|
I am completely indifferent to that change. At the moment, you and I are the only ones using it. And I don't expect many people to create custom context hooks for IDOM in the future. |
|
I decided not to do that. Came up with a nice solution using functions. I'm going to remove the |
rmorshea
force-pushed
the
fix-use-context-issue
branch
4 times, most recently
from
61b4dd6
to
5174ec4
Compare
rmorshea
force-pushed
the
fix-use-context-issue
branch
from
5174ec4
to
60feda7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #789
components which are newly added to the layout after the initial render do not have access to contexts. we solve this by tracking life cycle hooks in stack and copying the context providers from parent to child hooks.
Checklist:
Please update this checklist as you complete each item:
changelog.rsthas been updated with any significant changes.