Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite style props #936

Merged
merged 9 commits into from
Feb 23, 2023
Merged

Rewrite style props #936

merged 9 commits into from
Feb 23, 2023

Conversation

rmorshea
Copy link
Collaborator

@rmorshea rmorshea commented Feb 23, 2023

Checklist

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.
  • GitHub Issues which may be closed by this Pull Request have been linked.

@rmorshea rmorshea marked this pull request as ready for review February 23, 2023 03:04
@rmorshea rmorshea assigned Archmonger and unassigned Archmonger Feb 23, 2023
@Archmonger
Copy link
Contributor

Archmonger commented Feb 23, 2023

Do we want to tackle the custom_vdom_constructor pylint issues?

@rmorshea
Copy link
Collaborator Author

So custom_vdom_constructor actually does implement an overload. My suspicion is that pylint assumes decorators don't modify function interfaces - hence the error messages. IMO, if you're using MyPy you don't need PyLint. If you want to continue using it, I'd recommend just turning off this check.

@Archmonger
Copy link
Contributor

Pylint catches a lot of things that I've seen mypy miss. Typically that's a fairly useful error to retain.

It seems like a bug within Pylint, and the generally accepted solution is to directly call the decorator, rather than using the @ decorator operation.

https://stackoverflow.com/questions/40135129/pylint-getting-it-to-understand-decorators

@rmorshea rmorshea merged commit e8263de into main Feb 23, 2023
@rmorshea rmorshea deleted the rewrite-style-props branch February 23, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants