+tck #362 complete subscriber under test once done in 205 #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
approved these changes
May 29, 2017
viktorklang
reviewed
May 29, 2017
| } | ||
| }).required_spec205_blackbox_mustCallSubscriptionCancelIfItAlreadyHasAnSubscriptionAndReceivesAnotherOnSubscribeSignal(); | ||
|
|
||
| completion.await(1, TimeUnit.SECONDS); |
There was a problem hiding this comment.
Is 1s always appropriate here?
There was a problem hiding this comment.
Why not? Usually completes almost instant, why put tight timeouts?
There was a problem hiding this comment.
I don't know, hence the question. Since it is a "magic number" I was wondering how it was chosen. If you think it'll work fine for all impls then that's all I need :)
There was a problem hiding this comment.
Ok, yes it's enough.
It does not matter for different impls, this provides the impl and tests the tck, no different impls will be provided for this codepath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup to things found in #362