Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back TCK for 0.4.0 #91

Merged
merged 17 commits into from
Sep 19, 2014

Commits on Sep 2, 2014

  1. Revert "Temporarily Remove TCK Implementation"

    This reverts commit db606f7.
    
    Conflicts:
    	tck/src/main/resources/spec.md
    ktoso committed Sep 2, 2014
    Configuration menu
    Copy the full SHA
    826cef5 View commit details
    Browse the repository at this point in the history
  2. Initial come-back of TCK

    Includes:
    * Initial tests for spec rules for Publisher / Subscriber
    * The Processor specs delegate to all pub / sub specs
    * Additional Processor rules are REMAINS from the OLD TCK,
      and have not yet been pruned / cleaned up.
    * Added travis to build; there is only one test which validates that all
      pub / sub rules are properly delegated to from the processor test.
    * Tests now fail in isolation, previous TCK could cascade one test
      failure to multiple tests failing
    
    Please review and share feedback, it's still a bit early and needs more polish.
    The classes I would ask you to focus on are PublisherVerification and
    SubscriberVerification.
    ktoso committed Sep 2, 2014
    Configuration menu
    Copy the full SHA
    d8e1637 View commit details
    Browse the repository at this point in the history
  3. TCK: review follow ups and additional tests / blackbox tests

    * Make spec rules linkable (#2.13) and use links in TCK
    * Verified 1-element-publishers are testable with TCK (skips unsupported tests)
    + moved 3.2 from subscriber tests to publisher tests
    + moved 3.4 to publisher
    + moved 3.6 spec to Publisher
    + check rule 3.3, assuming publisher breaks the reccursion
    + Splitting subscriber whitebox / blackbox tests
    + both got verifications of rule 2.3
    + whitebox is the previous impl
    + blackbox is tests which work without any additional probes
      it mostly wrapps the subscriber in order to check things
    + better 2.10 verification in blackbox
    + test was testing onComplete instead of onError like it should
    + better blackbox tests for 2.9
    + more java-doc style java-docs (added {@link}s)
    + minor cleanups and refactors to make BlackboxProxy more understandable
    + added missing delegation of boundedDepthOfOnNextAndRequestRecursion
    + improved error message when expecting error message
    ktoso committed Sep 2, 2014
    Configuration menu
    Copy the full SHA
    187150a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9eba1ea View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5d1eca3 View commit details
    Browse the repository at this point in the history
  6. More fine-tuning of the specs, fixes of mistakes uncovered by akka-st…

    …reams
    
    + checking 3.9 in PublisherVerification
    + better error messages on expectThrowingOf
    + fixed 2.5 tests – they were checking the wrong things
    + checking 1.13 must be optional, because some publishers dont support fan-out
    + inverse condition in 3.13 to avoid NPE, and report a nice error
    + checking 1.7 should give more demand, then pull based publishers will
      notice that their source has been drained and complete the downstream
    + checking 1.13 should give more demand, as if the publisher is
      pull-based, it would not notice (and has 0 buffer space), it would not
      notice that it's source has been drained, and would not complete the
      stream.
    ktoso committed Sep 2, 2014
    Configuration menu
    Copy the full SHA
    a8a20e8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9952f84 View commit details
    Browse the repository at this point in the history
  8. + more logging in Processor verification

    + 3.9 check; fixes typo introduced during 0 semantics change
    + fixed typo in error string
    + reworked 2.12 test
    ktoso committed Sep 2, 2014
    Configuration menu
    Copy the full SHA
    3201c66 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    fe37d33 View commit details
    Browse the repository at this point in the history
  10. Remove mustUnblockTheStreamIfABlockingSubscriptionHasBeenCancelled

    Rationale:
    It was part of the previous TCK, but I find it hard to support for
    different kinds of Publishers we might have. One example being "hot"
    Publishers. One might argue that the TCK must then silence this test
    as it can not "buffer" the required amount of elements. Also, this test
    is not directly testing TCK rules directly (but involves the in-order
    requirements and buffering implicitly)...
    ktoso committed Sep 2, 2014
    Configuration menu
    Copy the full SHA
    db42e58 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    7a8c077 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2014

  1. Configuration menu
    Copy the full SHA
    d76ecaa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e6fb2ec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ccc0832 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4738a43 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2014

  1. Allow skipping tests which require more subscribers

    if your impl is not able to support multiple subscribers
    ktoso committed Sep 10, 2014
    Configuration menu
    Copy the full SHA
    cc7f204 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2014

  1. Configuration menu
    Copy the full SHA
    94665e8 View commit details
    Browse the repository at this point in the history