-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add one or many sidecar container options in Kubegres YAML #30
Comments
Thank you for your message. |
Hello, |
I am closing this issue. If you would like to make a suggestion about an alternative solution, please do not hesitate to make a comment. |
Hi @alex-arica ! I just stumbled upon this as I was adding metrics to all third-party stuff that I use. The way In the case of Kubernetes, this would be done by using sidecar containers, e.g:
Reasons to do it in a separate container:
Reasons to not deploy it in a separate
So I think that the question here was: is it possible to specify such sidecar containers that get attached to the
And considering that monitoring is a must-have for production services, this would be a really nice feature! |
This would make kubegres fit really nicely into other production-ready environments in kubernetes:
-> look at all those pretty graphs that tell you about stuff like your database CPU & memory usage, number of transaction per time, etc. (you can click on the images in the dashboard that I linked to see an example of what you get out of the box if only your postgres instance exports prometheus metrics) |
@LanDinh Thank you for sharing this. I agree that for those who prefer the sidecar option, it would add value to be able to specify one or many sidecars in Kubegres YAML. I am re-openning this issue and it will be about being able to specify one or many sidecars to Kubegres. Thank you. |
Any news on this? The missing option for sidecar containers is currently the major reason for not using Kubegres in production. Anything else works pretty fine. I really like the simplicity of Kubegres compared to other much more complex operators. Many thanks for this awesome work! |
I agree that it will a useful feature. If a developer is willing to implement this change, I am available to review their PR. We decided to let the community to be more involved in the project and therefore until end of summer 2022, I will only make a code changes when it is required. With this approach, we are hoping there would be additional developers involved in this project and more PRs submitted. |
@alex-arica can you add either @jgmartinez or me as assigned to this and #89? |
@CasperGN I assigned it to you. From now, I think you can assign it to anyone else if required. |
Prometheus is very popular with Kuberentes users and it'll be helpful to be able to deploy the postgres_exporter along ith postgres databaes instances so that the metrics can be collected by Proemtheus.
The text was updated successfully, but these errors were encountered: