enhance: Better handling of errors #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntucker
force-pushed
the
gql-errorhandling
branch
from
ef7da1a
to
c5eab5b
Compare
Codecov Report
@@ Coverage Diff @@
## master #2168 +/- ##
=======================================
Coverage 98.49% 98.49%
=======================================
Files 103 103
Lines 1933 1933
Branches 407 407
=======================================
Hits 1904 1904
Misses 13 13
Partials 16 16 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
notwillk
approved these changes
Sep 8, 2022
ntucker
force-pushed
the
gql-errorhandling
branch
from
9046763
to
b1a88ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
GQL can also have HTTP errors like REST
Solution
Steal logic from REST lib