Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: paginated() should replace all results to ensure updated cursor #2354

Merged
merged 1 commit into from
Jan 12, 2023
Merged

fix: paginated() should replace all results to ensure updated cursor #2354

merged 1 commit into from
Jan 12, 2023

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Jan 12, 2023

Fixes #2353 .

Motivation

Paginated requires getting the updated cursor, not the first page cursor

Solution

Based on the previous docs we need to be simply using the new results to completely replace other values like the cursor

@ntucker ntucker requested a review from notwillk January 12, 2023 09:09
@ntucker ntucker merged commit 95c9653 into master Jan 12, 2023
@ntucker ntucker deleted the fix/paginated branch January 12, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notwillk notwillk notwillk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination with infinite scroll example
2 participants
@ntucker @notwillk