-
-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: Test TypeScript 4.0, 4.1, 4.3 #2505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
7164818
to
d349906
Compare
9462f89
to
db44b0f
Compare
ntucker
added a commit
that referenced
this pull request
Mar 21, 2023
ntucker
added a commit
that referenced
this pull request
Mar 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
TS upgrade paths require libraries to support their old versions and new versions so they can first upgrade library, then TypeScript. This is in case the new TS introduces something that breaks in the library.
Also easier adoption for existing projects.
Solution
Generally we try to reduce as little functionality as possible, but when necessary we resort to looser types so it is at least compatible.
Core
EndpointUpdateFunction
, because versions prior to 4.8 do not correctly produce types when dealing with generics.Endpoint
PartialParameters
as a workaround for When trying to use mapped tuples as rest parameters error 'A rest parameter must be of an array type' given microsoft/TypeScript#29919Rest
OptionsToFunction
parameters...This is used to infer parameter types for .extend()RequiredKeys
utility which allows us to make urlParams optional if it contains no required memberssearchParams
member in paginated endpoint so extends works correctlyCI