Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove FetchShape ultra-legacy compat #2688

Merged
merged 1 commit into from Jul 3, 2023
Merged

enhance: Remove FetchShape ultra-legacy compat #2688

merged 1 commit into from Jul 3, 2023

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Jul 3, 2023

Motivation

Removing legacy support reduces bundle size, complexity, test time, and improves performance.

Solution

This removes compatibility with legacy hooks from 'rest-hooks' like useResource(), useMeta(), etc.

Remove rest-hooks package

We drop support for rest-hooks as it was an adapter layer based on legacy FetchShape compatibility. Users should upgrade to the latest version first to remove dependency on these hooks before moving to the next version.

Because support was dropped we remove it from the repo to simplify the codebase

@changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2023

🦋 Changeset detected

Latest commit: f46b43e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@rest-hooks/legacy Major
@rest-hooks/endpoint Major
@rest-hooks/rest Major
@data-client/endpoint Minor
@data-client/graphql Minor
@data-client/rest Minor
@rest-hooks/graphql Minor
@data-client/img Patch
example-benchmark Patch
normalizr-github-example Patch
normalizr-redux-example Patch
normalizr-relationships Patch
todo-app Patch
github-app Patch
next-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rest-hooks ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 4:21pm

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.42 ⚠️

Comparison is base (353e949) 98.05% compared to head (f7e3ec0) 97.63%.

❗ Current head f7e3ec0 differs from pull request most recent head f46b43e. Consider uploading reports for the commit f46b43e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2688      +/-   ##
==========================================
- Coverage   98.05%   97.63%   -0.42%     
==========================================
  Files         140      118      -22     
  Lines        2308     2068     -240     
  Branches      359      329      -30     
==========================================
- Hits         2263     2019     -244     
- Misses         19       24       +5     
+ Partials       26       25       -1     
Impacted Files Coverage Δ
packages/endpoint/src/index.ts 100.00% <ø> (ø)
packages/endpoint/src/indexEndpoint.ts 100.00% <ø> (ø)
packages/endpoint/src/endpoint.js 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ntucker ntucker marked this pull request as ready for review July 3, 2023 16:16
@ntucker ntucker merged commit 011cc20 into master Jul 3, 2023
22 checks passed
@ntucker ntucker deleted the no-shapes branch July 3, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant