Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Use custom SSRProvider for SSR rather than ExternalDataProvider #3112

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

ntucker
Copy link
Collaborator

@ntucker ntucker commented Jun 19, 2024

Motivation

Remove extraneous codepaths that only run on client since this component only runs on server side

Solution

Copy link

changeset-bot bot commented Jun 19, 2024

🦋 Changeset detected

Latest commit: b210c1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@data-client/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (4d8a8a5) to head (b210c1a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3112   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files         125      125           
  Lines        2230     2230           
  Branches      452      452           
=======================================
  Hits         2203     2203           
  Misses         16       16           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ntucker ntucker marked this pull request as ready for review June 19, 2024 09:59
@ntucker ntucker changed the title enhance: Use simplified SSR provider component rather than ExternalDa… enhance: Use custom SSRProvider for SSR rather than ExternalDataProvider Jun 19, 2024
@ntucker ntucker merged commit afe0640 into master Jun 19, 2024
24 checks passed
@ntucker ntucker deleted the ssr-optimize branch June 19, 2024 10:09
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant