feat: Entity fully denormalizes & Entity -> FlatEntity for non-nested #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntucker
force-pushed
the
full-denormalize
branch
2 times, most recently
from
f239289
to
0e25690
Compare
|
Size Change: +90 B (0%) Total Size: 26.9 kB
ℹ️ View Unchanged
|
ntucker
changed the title
ntucker
force-pushed
the
full-denormalize
branch
3 times, most recently
from
c631018
to
03a0268
Compare
ntucker
changed the title
ntucker
commented
May 4, 2020
| @@ -233,17 +233,16 @@ describe(`${Entity.name} normalization`, () => { | |||
| }); | |||
| }); | |||
|
|
|||
| /* TODO: This isn't supported quite yet | |||
There was a problem hiding this comment.
note we re-enable this entire block. This has a lot of interested recursively nested denormalization cases.
ntucker
commented
May 4, 2020
| @@ -32,14 +26,19 @@ import useSelectionUnstable from './react-integration/hooks/useSelection'; | |||
| import hasUsableData from './react-integration/hooks/hasUsableData'; | |||
| import { StateContext, DispatchContext } from './react-integration/context'; | |||
|
|
|||
| export { | |||
| Entity as NestedEntity, | |||
There was a problem hiding this comment.
remapping so there's no actual breaking changes for 'rest-hooks' itself (for now)
This was referenced May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #301, #277, #165.
Motivation
Lacking full denormalization is a regression from recent consolidation. This allows for that.
Solution
pktype.To maintain backwards compatibility, exports from 'rest-hooks' package itself will be
NestedEntityandEntity- that have previous behavior. New projects should importEntityandFlatEntityfrom@rest-hooks/normalizrdirectly.Open questions
The next step is to make referential equality last more than one denorm call.
Entity, and it's schema members will need to be the keys mapping into a fully denormalized object. These should be freed from memory as soon as all other references to the fully denormalized object are lost.