Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To observable change set #603

Merged
merged 6 commits into from
Jun 9, 2022
Merged

To observable change set #603

merged 6 commits into from
Jun 9, 2022

Conversation

RolandPheasant
Copy link
Collaborator

@RolandPheasant RolandPheasant commented Jun 9, 2022

Completely rework ToObservableChangeSet

Fixes #604 - see description for full details
Fixes #358 - behaviour change
Fixes #305 - memory leak
Reverts #326

@codecov-commenter
Copy link

Codecov Report

Merging #603 (ab5665e) into main (a6b4936) will decrease coverage by 0.27%.
The diff coverage is 98.47%.

❗ Current head ab5665e differs from pull request most recent head dc2a851. Consider uploading reports for the commit dc2a851 to get more accurate results

@@            Coverage Diff             @@
##             main     #603      +/-   ##
==========================================
- Coverage   71.46%   71.18%   -0.28%     
==========================================
  Files         215      215              
  Lines       10716    10697      -19     
==========================================
- Hits         7658     7615      -43     
- Misses       3058     3082      +24     
Impacted Files Coverage Δ
src/DynamicData/Cache/IntermediateCache.cs 45.00% <ø> (ø)
...micData/Cache/Internal/AnonymousObservableCache.cs 68.75% <ø> (ø)
src/DynamicData/Cache/Internal/Cache.cs 75.67% <ø> (+2.70%) ⬆️
...amicData/Cache/Internal/LockFreeObservableCache.cs 63.41% <ø> (ø)
src/DynamicData/Cache/ObservableCache.cs 79.86% <ø> (ø)
...DynamicData/List/Internal/ToObservableChangeSet.cs 98.59% <97.87%> (-0.19%) ⬇️
...ynamicData/Cache/Internal/ToObservableChangeSet.cs 98.87% <98.66%> (+4.03%) ⬆️
src/DynamicData/Cache/Internal/TimeExpirer.cs 59.55% <100.00%> (ø)
...namicData/List/Internal/AnonymousObservableList.cs 75.00% <100.00%> (ø)
src/DynamicData/List/Internal/ExpireAfter.cs 93.93% <100.00%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6b4936...dc2a851. Read the comment docs.

@RolandPheasant RolandPheasant marked this pull request as ready for review June 9, 2022 18:59
@RolandPheasant RolandPheasant merged commit 4375ab1 into main Jun 9, 2022
@RolandPheasant RolandPheasant deleted the ToObservableChangeSet branch June 9, 2022 19:19
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants