Fix API Checks, Add paragraphs to comments. #759
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
==========================================
+ Coverage 64.74% 65.46% +0.72%
==========================================
Files 226 227 +1
Lines 11459 11091 -368
Branches 2334 2294 -40
==========================================
- Hits 7419 7261 -158
+ Misses 3083 2889 -194
+ Partials 957 941 -16 ☔ View full report in Codecov by Sentry. |
| /// <returns> | ||
| /// A Task. | ||
| /// </returns> | ||
| public static async Task CheckApproval(this Assembly assembly, string[] namespaces, [CallerFilePath] string filePath = "") |
There was a problem hiding this comment.
Why an extension method, as opposed to just putting it directly in the test? Verifier.Verify() has its own [CallerFilePath] annotation, so calling directly should still work.
There was a problem hiding this comment.
It was brought over from rxui where multiple projects and tests are run against different frameworks etc. less of an issue with dynamicdata tho.
| @@ -1,10 +1,10 @@ | |||
| <Project Sdk="MSBuild.Sdk.Extras"> | |||
| <PropertyGroup> | |||
| <TargetFrameworks>net6.0;net7.0;net8.0</TargetFrameworks> | |||
| <NoWarn>$(NoWarn);CS0618;CA1801;CA1063;CS8767;CS8602; CS8618</NoWarn> | |||
| <NoWarn>$(NoWarn);CS0618;CA1801;CA1063;CS8767;CS8602;CS8618;IDE1006</NoWarn> | |||
There was a problem hiding this comment.
Was this an intentional addition? Cloning the branch and removing it, I don't actually see this popping up anywhere.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
API check now fails when doesn't match.